Replace brace with ace-build and react-ace #1331
Merged
+77
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
To enable users to remove the CSP directive
style-src unsafe-inline
, theace editor version needs to be upgraded to at least 1.4.13 which
includes the global option
useStrictCSP
. In order to do thisbrace has had to be replaced since it hasn't had an update in 4 years.
react-ace is chosen as a replacement as it uses ace-builds and wraps
ace in a react component. The option
useStrictCSP
is enabled,with the required style sheets imported, where possible properties
that can be handled by react-ace are passed directly to
AceEditor
as part of the
render()
call, otherwise customizations are leftto be handled by the codeeditor component.
Testing recommendations
The changes should be covered by the existing nightwatch tests and from an end user perspective the changes should be not be noticable.
GitHub issue number
n/a
Related Pull Requests
n/a
Checklist